Prevent uneccessary tile requests going out and being processed on response #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvanSanchez
reviewed
Mar 10, 2018
docs/demo-vectortiles.html
Outdated
| <script type="text/javascript" src="../src/Leaflet.VectorGrid.Protobuf.js"></script>--> | ||
| <script type="text/javascript" src="https://unpkg.com/leaflet@1.0.3/dist/leaflet.js"></script> | ||
| <!-- <script src="https://unpkg.com/leaflet.vectorgrid@1.2.0"></script> --> | ||
| <script type="text/javascript" src="./../dist/Leaflet.VectorGrid.bundled.js"></script> |
There was a problem hiding this comment.
Please note that this will fail "in production", i.e. when merged into the master branch and when a new build is released.
IvanSanchez
reviewed
Mar 10, 2018
docs/demo-vectortiles.html
Outdated
| <script type="text/javascript" src="../src/Leaflet.Renderer.Canvas.Tile.js"></script> | ||
| <script type="text/javascript" src="../src/Leaflet.VectorGrid.js"></script> | ||
| <script type="text/javascript" src="../src/Leaflet.VectorGrid.Protobuf.js"></script>--> | ||
| <script type="text/javascript" src="https://unpkg.com/leaflet@1.0.3/dist/leaflet.js"></script> |
There was a problem hiding this comment.
Upgrade to Leaflet 1.3.1 while we're at it?
IvanSanchez
reviewed
Mar 10, 2018
There was a problem hiding this comment.
Try using tile.current instead of the zoom level check, see https://github.com/Leaflet/Leaflet/blob/c7b5d1deba83ec9176c849ce71c85f27884a6280/src/layer/tile/GridLayer.js#L679
JamesLMilner
changed the title
IvanSanchez
approved these changes
Mar 10, 2018
sikmir
reviewed
Aug 26, 2021
| } | ||
| } | ||
|
|
||
| if (styleOptions instanceof Function) { | ||
| styleOptions = styleOptions(feat.properties, coords.z); |
There was a problem hiding this comment.
feat.type argument missed. See #130 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop doing unnecessary work for responses that come back for tiles on previous zoom levels.