Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ie6 filter clearing fix #667

Merged
merged 1 commit into from
May 5, 2012
Merged

ie6 filter clearing fix #667

merged 1 commit into from
May 5, 2012

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented May 5, 2012

Are we in 2012? Yes we are!

This is a "man vs machine" challenge rather than a real issue.

I'm working on a fork of Leaflet based on the master branch and I noticed that when you use the prehistoric IE6, marker icons disappears.

This is because the setOpacity method of DomUtil class resets the filter when opacity is 1.

Nice, but in this way it resets the AlphaImageLoader filter too, and it will result in an empty icon

Hope it helps

Best regards

GT

mourner added a commit that referenced this pull request May 5, 2012
@mourner mourner merged commit 8528b38 into Leaflet:master May 5, 2012
@mourner
Copy link
Member

mourner commented May 5, 2012

Thanks! The only issue that may appear is when you try to call, say, setOpacity(0.5) in IE6 several times - what will happen?

@tagliala
Copy link
Contributor Author

tagliala commented May 5, 2012

http://img694.imageshack.us/img694/5754/nuovo2.png

it works the same. Don't care about the gray background: I'm working on icon sprites and I don't care about IE6 support :)

(the red marker is loaded as a single image)

I'm working on this if you are interested:
https://github.com/tagliala/Leaflet/tree/icon-sprite
(CSS icon sprite section of readme)

@ajbeaven
Copy link
Contributor

This breaks popups in IE8 and earlier and apparently also this guys issue https://github.com/CloudMade/Leaflet/pull/600. What's the lesser of two evils?

@tagliala
Copy link
Contributor Author

Of course IE8 has priority. This patch could be improved with a regular expression on filter property, but this is not the case: simply let IE6 die :)

Sorry for causing unwanted side effects

@tagliala tagliala deleted the ie6-filter-fix branch April 18, 2022 11:17
@Malvoz Malvoz added the ie Internet Explorer label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ie Internet Explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants