Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ukraini dialog #8177

Merged
merged 4 commits into from
Apr 25, 2022
Merged

Add Ukraini dialog #8177

merged 4 commits into from
Apr 25, 2022

Conversation

Falke-Design
Copy link
Member

Replaces the existing Urkaini war site with an dialog.

With this change existing PRs don't get merge conflicts like #7818 and existing links, redirects are working again.
The dialog opens only once every 24 hours.

@mourner @IvanSanchez @Malvoz do you see any problems with the usage of sessionStorage and iframe?
The changed files for the dialog are:

  • /SlavaUkraini/*
  • index.html
  • /_layouts/v2.html
  • /docs/css/main.css

Here a demo. In the demo I changed that the dialog opens every 10 seconds again (on a site change).

docs/SlavaUkraini/dialog.js Outdated Show resolved Hide resolved
docs/docs/css/main.css Outdated Show resolved Hide resolved
@Malvoz Malvoz added the docs Improvements or additions to documentation label Apr 22, 2022
docs/SlavaUkraini/dialog.js Outdated Show resolved Hide resolved
@Malvoz
Copy link
Member

Malvoz commented Apr 22, 2022

The change to logo-ua.png is reverting @mourner's 3f22bb8.

Edit: it'd be neat to maintain the transparent background with the new colors though.

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I was thinking about moving it back to help with the conflicts, but the dialog idea is brilliant. 👍 from me apart from addressing things @Malvoz brought up.

@mourner
Copy link
Member

mourner commented Apr 22, 2022

Edit: it'd be neat to maintain the transparent background with the new colors though.

I thought about it, but it's only displayed on white background, and it actually looks better around the edges because the original logo source I have doesn't have proper transparency there, leading to some pixel artifacts. I think it's fine to keep it white bg.

docs/SlavaUkraini/dialog.js Outdated Show resolved Hide resolved
@Falke-Design Falke-Design requested review from Malvoz and mourner April 23, 2022 12:28
Copy link
Member

@Malvoz Malvoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well, nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants