-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ukraini dialog #8177
Add Ukraini dialog #8177
Conversation
The change to logo-ua.png is reverting @mourner's 3f22bb8. Edit: it'd be neat to maintain the transparent background with the new colors though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I was thinking about moving it back to help with the conflicts, but the dialog idea is brilliant. 👍 from me apart from addressing things @Malvoz brought up.
I thought about it, but it's only displayed on white background, and it actually looks better around the edges because the original logo source I have doesn't have proper transparency there, leading to some pixel artifacts. I think it's fine to keep it white bg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work well, nice!
Replaces the existing Urkaini war site with an dialog.
With this change existing PRs don't get merge conflicts like #7818 and existing links, redirects are working again.
The dialog opens only once every 24 hours.
@mourner @IvanSanchez @Malvoz do you see any problems with the usage of
sessionStorage
andiframe
?The changed files for the dialog are:
Here a demo. In the demo I changed that the dialog opens every 10 seconds again (on a site change).