Fix mouse accumulation #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are two paths forward with this PR:
The second is probably better, to avoid repeated wasted work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #538.
After substantial investigation, an upstream fix (that didn't end up being needed) and some serious refactoring, mouse motion and mouse scroll inputs tests are all green.
Basically, rather than summing the inputs in the middle of computing the raw inputs for each action, we're computing it once, in preupdate, and then fetching that value as a resource. This, unsurprisingly, should be upstreamed to bevy_input rather than living in LWIM.