This repository has been archived by the owner on Sep 3, 2022. It is now read-only.
Progress #1281 -- ObjectManager.Update, vision and spawn rewrite #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzardy
pushed a commit
that referenced
this pull request
Feb 4, 2022
…eamAboutVisibilityChange (#1295) Started splitting #1290 into separate pull requests, this is the first. `PacketNotifier` now has a function `NotifyVisibilityChange` (when we talked about it, it was called `NotifyVision`), which sends the appropriate packet about changing visibility depending on the type of object. Visibility updates for attacked units and particles are merged and moved to a separate function `UpdateVision` that calls `NotifyVision`. In fact, this is just the implementation of the idea [described in the message](https://discord.com/channels/166860156506865665/167010397428121601/937137082999119944) I also fixed a bug that I myself created by negligence: objects are no longer updated immediately after creation (because time has not passed since their creation) 😅
This was referenced Feb 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes (in no order):
autospawnfor particles.TeamHasVision- DEPRECATED,obj.IsVisibleByTeam(team)should be used instead.//TODO: Leave the option to force a vision update and a warning that it's not efficient?UpdateVisibilityAndSpawnIfNecessarytoObjectManagerlocks have been commented out as unnecessaryNavGridCellIsVisibleByTeamfunction inGameObject, now it usesuintand bitwise operations to store a list of teams that we can see the object with, which is more efficient.IsSpawnedandSetAsSpawnedfunctions have been added to theGameObject, replacing the_visionUnitslist in theObjectManager. In the future, they will allow to determine for clients from which teams the object has already been spawned, which will allow to spawn objects only when they first enter the visibility zone, reducing the likelihood of cheating (individual objects will spawn for everyone, for example, minions, the time and position of the appearance of which for no one secret), and also allow to solve the existing problem that if the particle was created outside the command's visibility zone, it will not be created when entering the visibility zone, as happens with attacked objects that have aNotifyEnterVisibilityClient.*VisionUnits- removed// TODO: send this in one place onlyare commented out because syncing everything and everything is done inGameManager.Update, but this may change in the future if a way is found to transmit only changes.ObjectManagertoObjAiBaseandSpellMissile.NotifyTeamVisibilityChangefunction has been added toPacketNotifier, which sends the appropriate packet based on the type of the object passed to it.