Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action manager fixes #507

Merged
merged 6 commits into from
Aug 5, 2022
Merged

Action manager fixes #507

merged 6 commits into from
Aug 5, 2022

Conversation

nzagorchev
Copy link
Contributor

@nzagorchev nzagorchev commented Aug 5, 2022 •
edited
Loading

What Where/Who
JIRA Issue SDK-1915
JIRA Issue SDK-1922
JIRA Issue SDK-1914
People Involved @nzagorchev

Background

Implementation

  • Enforce local caps in the executor, to prevent showing more messages than the configured cap once they are already in the queue.
  • Dismiss App Rating template so the queue can continue
  • Add OpenURL completion. Dismiss the OpenURL, add comment on edge cases when using multiple OpenURL actions one after another.

Testing steps

Is this change backwards-compatible?

@nzagorchev nzagorchev merged commit faf65b0 into master Aug 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the action-manager-fixes branch August 5, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborisoff hborisoff hborisoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzagorchev @hborisoff