Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ActionKind #514

Merged
merged 3 commits into from
Sep 19, 2022
Merged

Rename ActionKind #514

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
71de891
Rename ActionKind
nzagorchev Sep 18, 2022
e3a6b51
Update ActionManager+Tracking.swift
nzagorchev Sep 18, 2022
1b4748a
Rename ActionKind
nzagorchev Sep 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion LeanplumSDK/LeanplumSDK/Classes/Leanplum.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ typedef void (^LeanplumPushSetupBlock)(void);
typedef NS_OPTIONS(NSUInteger, LeanplumActionKind) {
kLeanplumActionKindMessage = 0b1,
kLeanplumActionKindAction = 0b10,
} NS_SWIFT_NAME(Leanplum.ActionKind);
} NS_SWIFT_NAME(LeanplumActionKind);

#define LP_PURCHASE_EVENT @"Purchase"

Expand Down
2 changes: 1 addition & 1 deletion LeanplumSDK/LeanplumSDK/ClassesSwift/Actions/ActionManager+Tracking.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import Foundation

extension ActionManager {
func recordImpression(action: Action) {
typealias Kind = Leanplum.ActionKind
typealias Kind = LeanplumActionKind

switch action.type {

Expand Down
4 changes: 2 additions & 2 deletions LeanplumSDK/LeanplumSDK/ClassesSwift/Actions/Models/ActionManager+ActionDefinition.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ extension ActionManager {
@objc public class ActionDefinition: NSObject {
@objc public let name: String
public let args: [ActionArg]
public let kind: Leanplum.ActionKind
public let kind: LeanplumActionKind
public let options: [String: String]

public var presentAction: ((ActionContext) -> (Bool))?
Expand All @@ -28,7 +28,7 @@ extension ActionManager {

@objc public required init(name: String,
args: [Any],
kind: Leanplum.ActionKind,
kind: LeanplumActionKind,
options: [String: String],
presentAction: ((ActionContext) -> (Bool))? = nil,
dismissAction: ((ActionContext) -> (Bool))? = nil) {
Expand Down