Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Support Notifications from both Leanplum and CleverTap
CT swizzling is not called (no swizzling of iOS delegate methods) when using a custom instance and the method is internal.
Instead of using double swizzling, check if the notification comes from Leanplum and if not, forward it to CleverTap to handle it using the
CleverTap.handlePushNotification
method.Implementation
Create a new
NotificationsManager
that inherits from it and handles both CT and LP notifications. Override the pushreceive
andopen
methods. Call the corresponding SDK based on the push payload. Handle registration with a device token as well.For CT, ensure that
CleverTap.handlePushNotification
andCleverTap.setPushToken
methods are called once we have an instance initialized.Set the push token when the CT instance is initialized, based on the token cached by Leanplum, using
instance.setPushTokenAs
.The Leanplum Notifications Object is also modified to not filter out the notifications. This logic is moved to the
NotificationsManager
.Note that CT does not send the "content-available" flag, so the app will not be woken up by a CT notification.
Example payloads
Leanplum
CleverTap
Testing steps
Testing Push is received and opened when:
Is this change backwards-compatible?
Yes