Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change device id hash length #532

Merged
merged 5 commits into from
Oct 25, 2022
Merged

Change device id hash length #532

merged 5 commits into from
Oct 25, 2022

Conversation

nzagorchev
Copy link
Contributor

@nzagorchev nzagorchev commented Oct 25, 2022 •
edited
Loading

What Where/Who
People Involved @nzagorchev

Background

  • Change deviceId hash length to 50, to minimize collisions for anonymous users.
  • Rename devices user property to lp_devices
  • Set lp_device for anonymous users, so merging multiple anonymous users does not override lp_devices
  • Use lp_devices for non-anonymous users only

Implementation

Testing steps

Is this change backwards-compatible?

@nzagorchev nzagorchev merged commit 8ee0ffb into master Oct 25, 2022
@delete-merged-branch delete-merged-branch bot deleted the device-hash branch October 25, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborisoff hborisoff hborisoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nzagorchev @hborisoff