Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes alerts raised by LGTM code reviews. (LL-192) #1457

Merged
merged 4 commits into from
Oct 9, 2019
Merged

fix: Fixes alerts raised by LGTM code reviews. (LL-192) #1457

merged 4 commits into from
Oct 9, 2019

Conversation

ryasmi
Copy link
Member

@ryasmi ryasmi commented Sep 20, 2019 •
edited
Loading

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2019

This pull request fixes 33 alerts when merging 94f7d45 into 7bf1fc3 - view on LGTM.com

fixed alerts:

  • 8 for Unused or undefined state property
  • 6 for Potentially unsafe external link
  • 5 for Superfluous trailing arguments
  • 4 for Direct state mutation
  • 3 for Useless conditional
  • 3 for Potentially inconsistent state update
  • 2 for Useless assignment to local variable
  • 1 for Implicit operand conversion
  • 1 for Unused variable, import, function or class

@ryasmi ryasmi changed the title ci(lgtm): Fixes warnings. ci(lgtm): Fixes alerts. Sep 20, 2019
@ryasmi ryasmi changed the title ci(lgtm): Fixes alerts. ci(lgtm): Fixes alerts. (LL-192) Sep 20, 2019
@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2019

This pull request fixes 33 alerts when merging 26a71ff into 098d0a9 - view on LGTM.com

fixed alerts:

  • 8 for Unused or undefined state property
  • 6 for Potentially unsafe external link
  • 5 for Superfluous trailing arguments
  • 4 for Direct state mutation
  • 3 for Useless conditional
  • 3 for Potentially inconsistent state update
  • 2 for Useless assignment to local variable
  • 1 for Implicit operand conversion
  • 1 for Unused variable, import, function or class

@ryasmi ryasmi changed the title ci(lgtm): Fixes alerts. (LL-192) fix: Fixes alerts raised by LGTM code reviews. (LL-192) Oct 9, 2019
@lgtm-com
Copy link

lgtm-com bot commented Oct 9, 2019

This pull request fixes 33 alerts when merging ff26192 into 89c7bb4 - view on LGTM.com

fixed alerts:

  • 8 for Unused or undefined state property
  • 6 for Potentially unsafe external link
  • 5 for Superfluous trailing arguments
  • 4 for Direct state mutation
  • 3 for Useless conditional
  • 3 for Potentially inconsistent state update
  • 2 for Useless assignment to local variable
  • 1 for Implicit operand conversion
  • 1 for Unused variable, import, function or class

@ryasmi ryasmi merged commit 990c8f7 into master Oct 9, 2019
@ryasmi ryasmi deleted the refactor-lgtm branch October 9, 2019 11:24
@HT2Bot
Copy link
Member

HT2Bot commented Oct 9, 2019

🎉 This PR is included in version 5.0.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@HT2Bot HT2Bot added the released label Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lydiamross lydiamross lydiamross approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryasmi @HT2Bot @lydiamross