-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renamed Curatr to Headstream[LL-217] #1476
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbishopvelti Was it already agreed to change only the occurrences that are actually displayed in the ui?
I'm just considering the work on improving the dev experience in that it could be confusing for new starters that the templates are still Curatr in the codebase.
Also, the apps page still says Curatr LXP and has the dinosaur logo, and the link probably needs consideration too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question as Lydia has. What about codebase matches and not the simple text changes? 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah as other comments suggest, I think we need to change references to this in the code too, we may need a migration if we want to change constants too. We should also change the logo to the new logo, please request that from Ollie.
ui/src/containers/Visualisations/TemplateStreamActivitiesWithMostComments/buildModel.js
Outdated
Show resolved
Hide resolved
🎉 This PR is included in version 6.0.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Please remember to request a review from someone when this PR is ready for a code review.
Which issue does this close?
Closes https://learningpool.atlassian.net/browse/LL-217.
Describe your changes providing screenshots of UI changes if necessary.