fix(Personas Import): Starting account names with a space breaks persona import (LL-273) #1495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 24, 2019 16:49
BREAKING CHANGE: Instead of createWriteStream is now used format method. Instead of "import csv from 'fast-csv" is now used "import * as csv from 'fast-csv'" Closes LL-273
Change import of csv module. Change method name from "createWriteStream" to "format" Closes LL-273
Closes LL-273
Closes LL-273
PrinceWaune
changed the title
PrinceWaune
changed the title
ryasmi
approved these changes
Jan 2, 2020
There was a problem hiding this comment.
Code looks fine, not totally clear that this fixes the issue although it looks like the changes to fast-csv in v3.2.0 might have fixed the problem although they don't have a test to cover the case.
|
🎉 This PR is included in version 6.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this close?
Closes https://learningpool.atlassian.net/browse/LL-273