fix(Statement Deletion): Fixes store recounts when clients have no LRS attached (LL-322) #1515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transfer the logic of recounts on single statement deletion from express-restify-mongoose to a post remove hook. Closes LL-322
added 2 commits
February 5, 2020 19:04
Closes LL-322
Closes LL-322
vladislav-999
approved these changes
Feb 7, 2020
|
@PrinceWaune , could you please annotate code inside |
Sure, no problem! |
added 2 commits
February 7, 2020 17:13
Closes LL-322
Closes LL-322
ryasmi
requested changes
Feb 13, 2020
There was a problem hiding this comment.
Thanks @PrinceWaune, looks good, just one thing to check and probably change.
Closes LL-322
ryasmi
approved these changes
Feb 17, 2020
ryasmi
changed the title
|
🎉 This PR is included in version 6.0.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://learningpool.atlassian.net/browse/LL-322.