Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Used but undeclared macro 'asm!'. #59

Merged
merged 2 commits into from
Jul 14, 2022
Merged

Conversation

Yakkhini
Copy link
Contributor

@Yakkhini Yakkhini commented Jul 9, 2022

It‘s an EMERGENCY fix!

I noticed that almost every lab repo autograding failed cause incorrect use of asm! macro in built-in riscv dependency, except:

  • They change their os2/Cargo.toml, make the riscv source to Gitee. In this case, line replace function in overwrite.py can't replace riscv to path ../ci-user/riscv
  • They just delete the replace function in overwrite.py, like Do not overwrite the riscv to local copy #17
  • They didn't set up classroom autograding in GitHub Actions, the deploy action works fine.

The built-in riscv dependency in ci-user must be unusable.

You said make test2 works fine in your environment, please check if your riscv source in Cargo.toml changed to Gitee, or your riscv's macro is correctly writed.

See more deep information, please check this commit.

@nooop3
Copy link

nooop3 commented Jul 10, 2022

Yes, the same error in the local and codespace environments. Related changes:

@Yakkhini
Copy link
Contributor Author

Yakkhini commented Jul 10, 2022

@chyyuu

图片

@chyyuu chyyuu merged commit 698d755 into LearningOS:main Jul 14, 2022
@chyyuu
Copy link
Member

chyyuu commented Jul 14, 2022

It works! Good JOB! Thanks you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants