Feature/confirm order #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[added state update to clear price and amount after confirmation] [references issue #13]
jondubois
requested changes
Apr 29, 2020
|
Fixed the code, you can take a look at it @jondubois |
jondubois
approved these changes
Apr 29, 2020
# Conflicts: # lisk-dex-electron/src/SignInModal.jsx
jondubois
reviewed
Apr 29, 2020
lisk-dex-electron/src/PlaceOrder.jsx
Outdated
| handleSubmit(event) { | ||
| event.preventDefault(); | ||
| this.clearErrors(); | ||
| if (this.validateOrder()) { | ||
| this.placeOrder(); | ||
| const confirmed = window.confirm(`Are you sure, you want to place this ${this.getOrderType()} order?`); |
There was a problem hiding this comment.
Are you sure you want to place this... (comma should not be there)
jondubois
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i.e. can think of adding custom confirmation dialog like this one
(https://github.com/GA-MO/react-confirm-alert)
https://stackoverflow.com/questions/37444906/how-to-stop-extensions-add-ons-like-grammarly-on-contenteditable-editors
Conflict with Grammarly chrome extension facebookarchive/draft-js#616
Fixes Clear the input boxes after submitting a limit or market order #13