Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Docker images with Nix #36
base: main
Are you sure you want to change the base?
Build Docker images with Nix #36
Changes from 6 commits
3c9bc56
b68716c
2867d33
b20aa90
47a8fe7
5c44ae3
fee2bae
25b219d
4fc323b
ed8f9ef
2cf882d
e9db7d5
a837243
f7be978
263f076
c498a36
c243e00
4def9cf
3b1e15e
788675e
d0fe09a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you wanted this to use PyPy instead, you would use the name of the PyPy derivation here instead - eg "pypy3".
If you want to try this, I suggest using a very recent version of nixpkgs master@HEAD (or waiting for the 23.05 release). I don't know if wormhole will have issues or not but I wasn't able to get Tahoe-LAFS to work on PyPy without a lot of hacking, even on the NixOS 22.11 release branch, due to a lot of Python package incompatibilities with PyPy that hadn't yet been addressed. But after 22.11 it looks like someone has paid a bit closer attention to PyPy support and it's a little easier.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the tip.
If we want to compare Debian vs NixOS images, PyPy would help indeed.
But I'm not sure how much time it will take (time was also an important factor).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to consider using a tool like npins or niv here, it will also make updating the pin much more pleasant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was looking into niv, but I could not see how/if it is used for PrivateStorageio!
(I've just made a copy/paste :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@exarkun : how do we update nixpkgs in PrivateStorageio?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The shell script
ci-tools/update-nixpkgs
calls, in its functionupdate_nixpkgs
on line 160,update-nixpkgs
defined intools/default.nix
line 17 viashell.nix
line 6. That in turn calls the python scripttools/update-nixpkgs
to updatenixpkgs.json
.The python script already broke once because the HTTP library it uses changed its API and we didn't have its version pinned.
That's why the moment @exarkun turns his back I'll replace the whole thing by my 12 line
update-nixpkgs.sh
shell script I have still sitting in my working directory which just creates a new JSON from a heredoc hr hr hrThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @hacklschorsch.
I was surprised there is not some nix command to do this...
And I was already trying to implement this in bash. :-)
I guess I'll not go further here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I think there are nix commands built-in when using flakes …
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not dare pushing this experiment to the flake level :-)
Nice to know this could help to simplify the update of the nixpkgs.
I'll see later if I can spend some extra time to improve this (with
npins
,niv
orflake
).Maybe interesting case for a "Nix Intro" session?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I won't be there this week because national holiday, but next week I could talk a bit about these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No business value in adding yet another way to update one three line json file.