refactor: add placeholders on the interface, when creating an offer. (#…

…60)
LedgerHQ · Jul 23, 2024 · 34fe77d · 34fe77d
1 parent 5e1a72c
commit 34fe77d
Show file tree

Hide file tree

Showing 16 changed files with 5 additions and 2 deletions.
diff --git a/libstellar/formatter.c b/libstellar/formatter.c
@@ -911,6 +911,7 @@ static bool format_manage_sell_offer(formatter_data_t *fdata) {
                 fdata->value_len))
         } else {
             STRLCPY(fdata->caption, "Create Offer", fdata->caption_len);
+            STRLCPY(fdata->value, "New Offer", fdata->value_len);
         }
         FORMATTER_CHECK(push_to_formatter_stack(&format_manage_sell_offer_buy))
     }
@@ -965,6 +966,7 @@ static bool format_manage_buy_offer(formatter_data_t *fdata) {
             FORMATTER_CHECK(print_uint64_num(op->offer_id, fdata->value, fdata->value_len))
         } else {
             STRLCPY(fdata->caption, "Create Offer", fdata->caption_len);
+            STRLCPY(fdata->value, "New Offer", fdata->value_len);
         }
         FORMATTER_CHECK(push_to_formatter_stack(&format_manage_buy_offer_sell))
     }

diff --git a/tests_generate_binary/package-lock.json b/tests_generate_binary/package-lock.json
diff --git a/tests_unit/testcases/opManageBuyOfferCreate.txt b/tests_unit/testcases/opManageBuyOfferCreate.txt
@@ -3,7 +3,7 @@ Max Fee; 0.00001 XLM
 Sequence Num; 103720918407102568
 Valid Before (UTC); 2022-12-12 04:12:12
 Tx Source; GDUTHC..XM2FN7
-Create Offer;
+Create Offer; New Offer
 Sell; BTC@GAT..MTCH
 Buy; 988,448,111.2222 XLM
 Price; 0.0001011 BTC/XLM

diff --git a/tests_unit/testcases/opManageSellOfferCreate.txt b/tests_unit/testcases/opManageSellOfferCreate.txt
@@ -3,7 +3,7 @@ Max Fee; 0.00001 XLM
 Sequence Num; 103720918407102568
 Valid Before (UTC); 2022-12-12 04:12:12
 Tx Source; GDUTHC..XM2FN7
-Create Offer;
+Create Offer; New Offer
 Buy; XLM
 Sell; 988,448,423.2134 BTC@GAT..MTCH
 Price; 0.0001234 XLM/BTC

diff --git a/tests_zemu/snapshots/flex-op-manage-buy-offer-create/00002.png b/tests_zemu/snapshots/flex-op-manage-buy-offer-create/00002.png
diff --git a/tests_zemu/snapshots/flex-op-manage-sell-offer-create/00002.png b/tests_zemu/snapshots/flex-op-manage-sell-offer-create/00002.png
diff --git a/tests_zemu/snapshots/s-op-manage-buy-offer-create/00006.png b/tests_zemu/snapshots/s-op-manage-buy-offer-create/00006.png
diff --git a/tests_zemu/snapshots/s-op-manage-sell-offer-create/00006.png b/tests_zemu/snapshots/s-op-manage-sell-offer-create/00006.png
diff --git a/tests_zemu/snapshots/sp-op-manage-buy-offer-create/00006.png b/tests_zemu/snapshots/sp-op-manage-buy-offer-create/00006.png
diff --git a/tests_zemu/snapshots/sp-op-manage-sell-offer-create/00006.png b/tests_zemu/snapshots/sp-op-manage-sell-offer-create/00006.png
diff --git a/tests_zemu/snapshots/stax-op-manage-buy-offer-create/00002.png b/tests_zemu/snapshots/stax-op-manage-buy-offer-create/00002.png
diff --git a/tests_zemu/snapshots/stax-op-manage-buy-offer-create/00003.png b/tests_zemu/snapshots/stax-op-manage-buy-offer-create/00003.png
diff --git a/tests_zemu/snapshots/stax-op-manage-sell-offer-create/00002.png b/tests_zemu/snapshots/stax-op-manage-sell-offer-create/00002.png
diff --git a/tests_zemu/snapshots/stax-op-manage-sell-offer-create/00003.png b/tests_zemu/snapshots/stax-op-manage-sell-offer-create/00003.png
diff --git a/tests_zemu/snapshots/x-op-manage-buy-offer-create/00006.png b/tests_zemu/snapshots/x-op-manage-buy-offer-create/00006.png
diff --git a/tests_zemu/snapshots/x-op-manage-sell-offer-create/00006.png b/tests_zemu/snapshots/x-op-manage-sell-offer-create/00006.png