✨ (signer-btc) [DSDK-485]: Implement getWalletAddress task #567
+409
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
fAnselmi-Ledger
force-pushed
the
feat/DSDK-485-ts-signer-implement-get-wallet-address-task
branch
from
7d94a24 to
cc92710
Compare
fAnselmi-Ledger
force-pushed
the
feat/DSDK-485-ts-signer-implement-get-wallet-address-task
branch
from
cc92710 to
87fea6a
Compare
jiyuzhuang
reviewed
Dec 19, 2024
| import { DataStore } from "@internal/data-store/model/DataStore"; | ||
| import { Sha256HasherService } from "@internal/merkle-tree/service/Sha256HasherService"; | ||
| import { CommandUtils } from "@internal/utils/CommandUtils"; | ||
| import { CommandUtils as BtcCommandUtils } from "@internal/utils/CommandUtils"; |
There was a problem hiding this comment.
This is the same object to the one in previous line, isn't it ?
| yieldedResults: [], | ||
| }; | ||
|
|
||
| const walletSerializer = new DefaultWalletSerializer( |
There was a problem hiding this comment.
this should be injected in the constructor
| async run(): Promise<CommandResult<GetWalletAddressCommandResponse, void>> { | ||
| const { display, wallet, change, addressIndex } = this.args; | ||
|
|
||
| const dataStore = new DataStore(); |
There was a problem hiding this comment.
you should probably either merkleize the wallet in that datastore, or get an injected datastore in the constructor, or did I miss something ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Implement getWalletAddress task
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers