Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add check on the app name unicity #89

Merged
merged 2 commits into from
Sep 27, 2023
Merged

Add check on the app name unicity #89

merged 2 commits into from
Sep 27, 2023

Conversation

tdejoigny-ledger
Copy link
Contributor

No description provided.

@tdejoigny-ledger
Copy link
Contributor Author

@xchapron-ledger not sure to understand what is checked in this function check_database_appnames(database_path: Path):

@xchapron-ledger
Copy link
Contributor

xchapron-ledger commented Sep 27, 2023 •
edited
Loading

@xchapron-ledger not sure to understand what is checked in this function check_database_appnames(database_path: Path):

The purpose of this function is to check for APPNAME unicity.
If detects if two variants have the same APPNAME.

xchapron-ledger
xchapron-ledger reviewed Sep 27, 2023
View reviewed changes
Copy link
Contributor

@xchapron-ledger xchapron-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can find a way to explicit the conflicting variant?
Something based on the other APPNAME conflict checker for example?

@tdejoigny-ledger tdejoigny-ledger merged commit 110eb00 into main Sep 27, 2023
1 check passed
@tdejoigny-ledger tdejoigny-ledger deleted the tdj/check_app_name branch September 27, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbeutin-ledger fbeutin-ledger fbeutin-ledger left review comments

@xchapron-ledger xchapron-ledger xchapron-ledger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdejoigny-ledger @xchapron-ledger @fbeutin-ledger