This repository has been archived by the owner on Jul 15, 2022. It is now read-only.
Fixes BL 1.3.1 support #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gre
requested review from
btchip,
amougel,
Arnaud97234,
flocks,
juan-cortes,
meriadec,
MortalKastor and
valpinkman
juan-cortes
approved these changes
May 4, 2019
|
Ready to merge bossman |
amougel
approved these changes
May 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In recent refactoring of
getDeviceInfo(andgetVersion) to support more version patterns (1.6.0-rc1 kind of versionning), we've broken the support of 1.3.1 Bootloader that was not returning any seVersion at all (it was"") which means users can't upgrade from 1.3.1 anymore exclusively when using Ledger Live 1.8.0.Mitigation
Use Ledger Live 1.7.0 to upgrade from Nano S 1.3.1.
https://github.com/LedgerHQ/ledger-live-desktop/releases/tag/v1.7.0
Solution
Provided in this PR, will be delivered in the next Ledger Live. We've rollbacked some previous code that was fallbacking on version
"0.0.0"when"". It will make things like the repair tool to work again.Important note for devs
Added one more test so we are sure to never regress on this. that show us our lack of test in the past, important to continue adding more and more test in the future.
Everytime you have a new firmware version or a new pattern, please always add a test / tell the LL team what are the output of getVersion so we add this test in our side. thanks.
test plan: #235