Ensure sqlite folder is removed after clear cache / hard reset #1585

meriadec · 2018-10-16T11:59:45Z

Clean cache / hard reset has been reported (& reproduced) failing to remove the <user-data>/sqlite folder on Windows (high chance of folder being "hold" by some process, even if we kill libcore before..) and we get some EPERM and ENOTEMPTY (relatable: isaacs/rimraf#72).

Fallback here is to detect this behaviour, and provide a workaround: open the user data folder then quit the app, explaining the user he has to delete manually.

Additionally for support guys, here is a video of the process (@dasilvarosa feel free to discuss the wording):

DEMO:

closes LedgerHQ#1554

src/components/SettingsPage/CleanButton.js

src/components/SettingsPage/ResetButton.js

gre · 2018-10-16T14:20:00Z

src/components/SettingsPage/ResetFallbackModal.js

+        title="Couldnt remove app files"
+        desc={
+          <div>
+            <p>{'Cache folder couldnt be deleted. You will have to delete it manually.'}</p>


we need to have all these texts put in wording.

src/helpers/reset.js

gre · 2018-10-16T14:21:51Z

@dasilvarosa could you check wording? thx

Arnaud97234 · 2018-10-16T17:29:16Z

No regression on macos and Ubuntu, sqlite folder is removed without need for user to delete the folder manually (even when application is syncing).

On Windows if "Clear cache" or "Reset Ledger Live" action is made just after sync ends, sqlite folder is removed without need for user to delete it manually.
If sqlite folder can't be removed automatically, the user will have to remove it manually.
A popup is displayed, on click on "Open folder" button app folder opens and Ledger Live process is killed. After removing sqlite folder, it's necessary to manually restart Ledger Live application.

dasilvarosa · 2018-10-16T17:31:11Z

static/i18n/en/app.json

@@ -406,6 +406,13 @@
      "title": "Clear cache",
      "desc": "Clearing the Ledger Live cache forces network resynchronization. Your settings and accounts are not affected. The private keys to access your crypto assets in the blockchain remain secure on your Ledger device and on your Recovery sheet."
    },
+    "resetFallbackModal": {
+      "part1": "Cache folder couldnt be deleted. You will have to delete it manually.",


"part1": "Could not delete cache folder. Please delete the folder manually:",

dasilvarosa · 2018-10-16T17:34:02Z

static/i18n/en/app.json

@@ -406,6 +406,13 @@
      "title": "Clear cache",
      "desc": "Clearing the Ledger Live cache forces network resynchronization. Your settings and accounts are not affected. The private keys to access your crypto assets in the blockchain remain secure on your Ledger device and on your Recovery sheet."
    },
+    "resetFallbackModal": {
+      "part1": "Cache folder couldnt be deleted. You will have to delete it manually.",
+      "part2": "Click on \"Open folder\", then the ",


"part2": "Click the Open folder button, the ",

dasilvarosa · 2018-10-16T17:36:11Z

static/i18n/en/app.json

+      "part1": "Cache folder couldnt be deleted. You will have to delete it manually.",
+      "part2": "Click on \"Open folder\", then the ",
+      "part3": "app will close",
+      "part4": ", and you will have to delete the \"sqlite\" folder.",


"part4": ", make sure to delete the "sqlite" folder.",

dasilvarosa · 2018-10-16T17:37:12Z

static/i18n/en/app.json

+      "part2": "Click on \"Open folder\", then the ",
+      "part3": "app will close",
+      "part4": ", and you will have to delete the \"sqlite\" folder.",
+      "part5": "After that, you can restart the app."


"part5": "Then you can restart the app normally."

dasilvarosa · 2018-10-16T17:41:32Z

src/components/SettingsPage/ResetFallbackModal.js

@@ -24,18 +26,20 @@ class ResetFallbackModal extends PureComponent<Props> {
        title="Couldnt remove app files"


title="User action required"

gre · 2018-10-16T19:27:36Z

Accidentally resolved one conversation but I think you can find it in history. Dumb GitHub big buttons on mobile.
Just wanted to say there are some remaining words not in translation files but only few 😀

meriadec · 2018-10-17T08:10:05Z

Updated !

dasilvarosa

Final wording polish ;). I recommend taking away the underline on the app will close, because it distracts from the more important info of deleting the sqlite folder.

dasilvarosa · 2018-10-17T08:20:18Z

static/i18n/en/app.json

      "part3": "app will close",
-      "part4": ", and you will have to delete the \"sqlite\" folder.",
-      "part5": "After that, you can restart the app."
+      "part4": ", make sure to delete the \"sqlite\" folder.",


"part4": ", and manually delete the "sqlite" folder.",

meriadec · 2018-10-17T09:18:56Z

Updated !

Ensure sqlite folder is removed after clear cache / hard reset

7c20887

closes LedgerHQ#1554

meriadec added HODL for PRs: this is blocked, we can't merge yet and removed HODL for PRs: this is blocked, we can't merge yet labels Oct 16, 2018

gre requested a review from Arnaud97234 October 16, 2018 14:17

gre suggested changes Oct 16, 2018

View reviewed changes

gre requested a review from dasilvarosa October 16, 2018 14:21

Add reset fallback translations & logs

2607b84

gre previously approved these changes Oct 16, 2018

View reviewed changes

Arnaud97234 previously approved these changes Oct 16, 2018

View reviewed changes

dasilvarosa suggested changes Oct 16, 2018

View reviewed changes

meriadec dismissed stale reviews from Arnaud97234 and gre via f97f592 October 17, 2018 08:09

dasilvarosa suggested changes Oct 17, 2018

View reviewed changes

Update ResetFallbackModal wording

a9c7467

meriadec force-pushed the fix-1554-reset branch from f97f592 to a9c7467 Compare October 17, 2018 09:18

gre requested a review from dasilvarosa October 17, 2018 10:21

gre approved these changes Oct 17, 2018

View reviewed changes

dasilvarosa approved these changes Oct 17, 2018

View reviewed changes

gre merged commit 8926b50 into LedgerHQ:develop Oct 17, 2018

meriadec deleted the fix-1554-reset branch October 29, 2018 21:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ensure sqlite folder is removed after clear cache / hard reset #1585

Ensure sqlite folder is removed after clear cache / hard reset #1585

meriadec commented Oct 16, 2018 •

edited

Loading

gre Oct 16, 2018

gre commented Oct 16, 2018

Arnaud97234 commented Oct 16, 2018

dasilvarosa Oct 16, 2018

dasilvarosa Oct 16, 2018

dasilvarosa Oct 16, 2018

dasilvarosa Oct 16, 2018

dasilvarosa Oct 16, 2018

meriadec Oct 16, 2018

gre commented Oct 16, 2018

meriadec commented Oct 17, 2018 •

edited

Loading

dasilvarosa left a comment •

edited

Loading

dasilvarosa Oct 17, 2018

meriadec commented Oct 17, 2018

		@@ -24,18 +26,20 @@ class ResetFallbackModal extends PureComponent<Props> {
		title="Couldnt remove app files"

Ensure sqlite folder is removed after clear cache / hard reset #1585

Ensure sqlite folder is removed after clear cache / hard reset #1585

Conversation

meriadec commented Oct 16, 2018 • edited Loading

Choose a reason for hiding this comment

gre commented Oct 16, 2018

Arnaud97234 commented Oct 16, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gre commented Oct 16, 2018

meriadec commented Oct 17, 2018 • edited Loading

dasilvarosa left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

meriadec commented Oct 17, 2018

meriadec commented Oct 16, 2018 •

edited

Loading

meriadec commented Oct 17, 2018 •

edited

Loading

dasilvarosa left a comment •

edited

Loading