added settings testIds

LedgerHQ · Apr 27, 2022 · 612eeb8 · 612eeb8
1 parent 77f2366
commit 612eeb8
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 11 deletions.
diff --git a/e2e/models/settings/generalSettingsPage.js b/e2e/models/settings/generalSettingsPage.js
@@ -2,18 +2,19 @@ import * as testHelpers from "../../helpers";
 
 export default class GeneralSettingsPage {
   static async togglePassword() {
-    await testHelpers.scrollToElementById(
-      "password-settings-toggle",
-      "general-settings-scroll-view",
-      200,
-    );
+    // scroll not needed for now
+    // await testHelpers.scrollToElementById(
+    //   "password-settings-toggle",
+    //   "general-settings-scroll-view",
+    //   200,
+    // );
 
     await testHelpers.tap("password-settings-toggle");
   }
 
   static async enterNewPassword(passwordText) {
     await testHelpers.typeText("password-text-input", passwordText);
-    await testHelpers.tap("Proceed");
+    await testHelpers.tap("Confirm");
   }
 
   static async isVisible() {

diff --git a/e2e/specs/onboarding.spec.js b/e2e/specs/onboarding.spec.js
@@ -7,7 +7,7 @@ describe("Onboarding", () => {
     console.log("==============> STARTING ONBOARDING DEVICE LAUNCH");
     // await device.reloadReactNative();
     // await device.launchApp({ newInstance: true });
-    await device.launchApp({ delete: true });
+    await device.launchApp();
   });
 
   it("should be able to connect a Nano X", async () => {

diff --git a/e2e/specs/password.spec.js b/e2e/specs/password.spec.js
@@ -10,9 +10,7 @@ const CORRECT_PASSWORD = "passWORD$123!";
 describe("Password Lock Screen", () => {
   beforeAll(async () => {
     console.log("==============> STARTING PASSWORD DEVICE LAUNCH");
-    // await device.launchApp({ newInstance: false });
     // await device.reloadReactNative();
-    console.log("==============> LAUNCH APP BEFORE ALL");
     await device.launchApp({ delete: true });
   });
 

diff --git a/src/components/SettingsCard.tsx b/src/components/SettingsCard.tsx
@@ -12,6 +12,7 @@ type Props = {
   Icon: IconType;
   onClick: Function;
   arrowRight?: boolean;
+  settingsCardTestId?: string;
 };
 
 function Card({
@@ -48,6 +49,7 @@ export default function SettingsCard({
   Icon,
   onClick,
   arrowRight,
+  settingsCardTestId,
 }: Props) {
   return (
     <StyledCard onPress={onClick}>
@@ -59,7 +61,7 @@ export default function SettingsCard({
         borderColor={"primary.c80"}
         iconColor={"primary.c80"}
       />
-      <Box ml={6} flex={1}>
+      <Box ml={6} flex={1} testID={settingsCardTestId}>
         <Text variant={"large"} fontWeight={"semiBold"} color={"neutral.c100"}>
           {title}
         </Text>

diff --git a/src/screens/Settings/General/AuthSecurityToggle.tsx b/src/screens/Settings/General/AuthSecurityToggle.tsx
@@ -28,7 +28,11 @@ export default function AuthSecurityToggle() {
         title={t("settings.display.password")}
         desc={t("settings.display.passwordDesc")}
       >
-        <Switch checked={!!privacy} onChange={onValueChange} />
+        <Switch
+          checked={!!privacy}
+          onChange={onValueChange}
+          testID="password-settings-toggle"
+        />
       </SettingsRow>
       {privacy ? <BiometricsRow /> : null}
     </>

diff --git a/src/screens/Settings/General/PasswordForm.tsx b/src/screens/Settings/General/PasswordForm.tsx
@@ -58,6 +58,7 @@ class PasswordForm extends PureComponent<Props, State> {
               secureTextEntry={secureTextEntry}
               placeholder={placeholder}
               password={value}
+              testID="password-text-input"
             />
           </View>
           {error && (

diff --git a/src/screens/Settings/index.tsx b/src/screens/Settings/index.tsx
@@ -52,6 +52,7 @@ export default function Settings({ navigation }: Props) {
         Icon={Icons.MobileMedium}
         onClick={() => navigation.navigate(ScreenName.GeneralSettings)}
         arrowRight
+        settingsCardTestId="general-settings-card"
       />
       {accounts.length > 0 && (
         <SettingsCard