Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

[LIVE-1174] - Feature: Upgrade NFT Architecture LLM V3 #2363

Merged
merged 35 commits into from
May 5, 2022

Conversation

lambertkevin
Copy link
Contributor

@lambertkevin lambertkevin commented Mar 30, 2022

Dependency

LedgerHQ/ledger-live-common#1938

Type

Feature

Context

Refactoring needing for the new NFT architecture + switch to TS for NFT related components

Parts of the app affected / Test plan

Non reg on ETH NFTs

@lambertkevin lambertkevin requested a review from a team March 30, 2022 15:20
@lambertkevin lambertkevin requested review from a team as code owners March 30, 2022 15:20
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from d17caf1 to f328262 Compare March 31, 2022 09:05
@LFBarreto LFBarreto added the HODL label Mar 31, 2022
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 6c1f074 to 05a88ff Compare March 31, 2022 13:36
@lambertkevin lambertkevin changed the base branch from develop to release/v3.0.x March 31, 2022 13:52
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch 2 times, most recently from bfc68bc to 13ccd20 Compare March 31, 2022 19:09
@lambertkevin lambertkevin changed the base branch from release/v3.0.x to develop April 1, 2022 08:36
@lambertkevin lambertkevin changed the base branch from develop to release/v3.0.x April 1, 2022 08:37
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 193be5a to 13ccd20 Compare April 1, 2022 08:37
@lambertkevin lambertkevin added dependencies Pull requests that update a dependency file and removed HODL labels Apr 1, 2022
Base automatically changed from release/v3.0.x to develop April 22, 2022 10:24
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch 3 times, most recently from a826ea4 to 716e9c7 Compare April 26, 2022 08:28
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch 3 times, most recently from 93bf5d6 to a33d188 Compare May 4, 2022 15:33
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from a33d188 to 93b5b67 Compare May 4, 2022 15:37
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 93b5b67 to 0d94747 Compare May 4, 2022 15:50
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick pass with 1st feedbacks

package.json Outdated Show resolved Hide resolved
src/components/Nft/NftCollectionRow.tsx Outdated Show resolved Hide resolved
src/components/Nft/NftCollectionRow.tsx Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2nd and last pass.
Mostly flagging potential optional chaining + a dumb question.

src/components/Nft/NftViewer.tsx Outdated Show resolved Hide resolved
src/components/Nft/NftViewer.tsx Outdated Show resolved Hide resolved
src/components/Nft/NftViewer.tsx Outdated Show resolved Hide resolved
src/components/Nft/NftViewer.tsx Outdated Show resolved Hide resolved
src/components/Skeleton.tsx Show resolved Hide resolved
src/screens/SendFunds/01b-SelectCollection.tsx Outdated Show resolved Hide resolved
src/screens/SendFunds/01c-SelectNft.tsx Outdated Show resolved Hide resolved
src/screens/SendFunds/01c-SelectNft.tsx Outdated Show resolved Hide resolved
src/screens/SendFunds/01c-SelectNft.tsx Outdated Show resolved Hide resolved
src/screens/SendFunds/03b-AmountNft.tsx Outdated Show resolved Hide resolved
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple lint issues in the CI.

@lambertkevin
Copy link
Contributor Author

A couple lint issues in the CI.

Problem is I can't fix most of them, cause we're still running flow check on .tsx files 😞

@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch from 5b463f7 to 01a9150 Compare May 4, 2022 18:49
@lambertkevin lambertkevin force-pushed the feat/upgrade-nft-architecture-v3 branch 2 times, most recently from 3811eb2 to f6bd615 Compare May 4, 2022 20:23
@lambertkevin lambertkevin requested a review from a user May 5, 2022 07:52
@ghost
Copy link

ghost commented May 5, 2022

(Lint errors in CI are flow errors on TS files...)

@lambertkevin lambertkevin added feature-ready and removed dependencies Pull requests that update a dependency file labels May 5, 2022
@lambertkevin lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:31
@valpinkman valpinkman merged commit 288f00e into release/3.1.x May 5, 2022
@valpinkman valpinkman deleted the feat/upgrade-nft-architecture-v3 branch May 5, 2022 13:35
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants