This repository has been archived by the owner on Jun 16, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 114
[LIVE-1174] - Feature: Upgrade NFT Architecture LLM V3 #2363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
March 31, 2022 09:05
d17caf1
to
f328262
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
March 31, 2022 13:36
6c1f074
to
05a88ff
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
2 times, most recently
from
March 31, 2022 19:09
bfc68bc
to
13ccd20
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
April 1, 2022 08:37
193be5a
to
13ccd20
Compare
This was referenced Apr 1, 2022
lambertkevin
added
dependencies
Pull requests that update a dependency file
and removed
HODL
labels
Apr 1, 2022
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
3 times, most recently
from
April 26, 2022 08:28
a826ea4
to
716e9c7
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
3 times, most recently
from
May 4, 2022 15:33
93bf5d6
to
a33d188
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 4, 2022 15:37
a33d188
to
93b5b67
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 4, 2022 15:50
93b5b67
to
0d94747
Compare
ghost
reviewed
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick pass with 1st feedbacks
ghost
reviewed
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2nd and last pass.
Mostly flagging potential optional chaining + a dumb question.
ghost
suggested changes
May 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple lint issues in the CI.
Problem is I can't fix most of them, cause we're still running flow check on .tsx files 😞 |
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
from
May 4, 2022 18:49
5b463f7
to
01a9150
Compare
lambertkevin
force-pushed
the
feat/upgrade-nft-architecture-v3
branch
2 times, most recently
from
May 4, 2022 20:23
3811eb2
to
f6bd615
Compare
ghost
approved these changes
May 5, 2022
(Lint errors in CI are flow errors on TS files...) |
lambertkevin
added
feature-ready
and removed
dependencies
Pull requests that update a dependency file
labels
May 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency
LedgerHQ/ledger-live-common#1938
Type
Feature
Context
Refactoring needing for the new NFT architecture + switch to TS for NFT related components
Parts of the app affected / Test plan
Non reg on ETH NFTs