Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Terms of use update popup #2442

Merged
merged 16 commits into from
May 5, 2022
Merged

Terms of use update popup #2442

merged 16 commits into from
May 5, 2022

Conversation

thomasrogerlux
Copy link
Contributor

@thomasrogerlux thomasrogerlux commented Apr 19, 2022

LIVE-1914

We wish to notify users properly when the Terms of Use gets updated, directly through Ledger Live. This PR add a new modal in the Portfolio component that will open when the accepted value from the terms context is false and the user isn't in the onboarding. Closing the modal accepts the new terms.

Screenshot from 2022-05-04 16-52-25

Parts of the app affected / Test plan

  • Portfolio
  • New CheckTermOfUseUpdate component
  • Terms of uses

@thomasrogerlux thomasrogerlux marked this pull request as ready for review April 19, 2022 15:42
@thomasrogerlux thomasrogerlux requested a review from a team as a code owner April 19, 2022 15:42
Base automatically changed from release/v3.0.x to develop April 22, 2022 10:24
Copy link
Contributor

@ThomasLaforge ThomasLaforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comparing dates is much better than the old comparison of string IMO. Good one !

@cgrellard-ledger
Copy link
Contributor

cgrellard-ledger commented May 4, 2022

Do we want to display the close button in the top right corner ?
Modal will be blocking user has to click on “Continue” <= from the specs

@thomasrogerlux
Copy link
Contributor Author

Do we want to display the close button in the top right corner ? Modal will be blocking user has to click on “Continue” <= from the specs

It's removed, I need to update the screenshot in the comment

@nparigi-ledger
Copy link
Contributor

nparigi-ledger commented May 5, 2022

Tested it by putting currentTermsRequired at a far away date.
The modal is popping without problem and the link is working.
Tested in spanish. The terms of use redirect to the spanish version of terms of use.
Tested in russian. As it doesn't seems to exist, it use the english version as fallback.

✔️

@lambertkevin lambertkevin changed the base branch from develop to release/3.1.x May 5, 2022 13:31
@valpinkman valpinkman merged commit d358b9a into release/3.1.x May 5, 2022
@valpinkman valpinkman deleted the feat/tos-update-popup branch May 5, 2022 13:37
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants