Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

LL-2228 - Qr code scan screen - UI Fix #2479

Conversation

nparigi-ledger
Copy link
Contributor

Qr code scan screen - Move alert to top layer so the ui doesn't overflow anymore

Before :

image

After :

Screenshot_20220503-193401_LL  DEV

Type

Bug fix

Context

https://ledgerhq.atlassian.net/browse/LIVE-2228

Parts of the app affected / Test plan

Import account -> QR Code scan

@nparigi-ledger nparigi-ledger requested a review from a team as a code owner May 3, 2022 17:43
@github-actions
Copy link

github-actions bot commented May 3, 2022

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

Copy link
Contributor

@ThomasLaforge ThomasLaforge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's a "top" fix :p

Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 reviewed & tested

@ofreyssinet-ledger ofreyssinet-ledger merged commit aea510d into develop May 4, 2022
@ofreyssinet-ledger ofreyssinet-ledger deleted the bugfix/LIVE-2228-qr-code-scan-screen-import-accounts-ui-fix branch May 4, 2022 08:46
This was referenced May 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants