Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

Fixed a bug that was redirecting to a blank page when deleting an account #2493

Merged
merged 1 commit into from
May 6, 2022

Conversation

cgrellard-ledger
Copy link
Contributor

@cgrellard-ledger cgrellard-ledger commented May 6, 2022

after.mp4
before.mp4

Type

Context

Parts of the app affected / Test plan

@cgrellard-ledger cgrellard-ledger requested a review from a team as a code owner May 6, 2022 13:25
@github-actions
Copy link

github-actions bot commented May 6, 2022

Thanks for your contribution.
To be able to merge in develop branch, you need to:

  • pass the CI
  • if needed, run /generate-screenshots
  • have a dev review
  • have a QA review
  • if needed, /upgrade-llc

Why /generate-screenshots ?

If your PR contains UI related changes,
it might be necessary to regenerate screenshots.

Why /upgrade-llc ?

If your PR requires an update to the ledger-live-common library,
once the PR is merged on develop on ledger-live-common side,
you need to run /upgrade-llc to switch back to ledger-live-common@develop here before merging.

@cgrellard-ledger cgrellard-ledger changed the base branch from develop to release/3.1.x May 6, 2022 13:52
@cgrellard-ledger cgrellard-ledger force-pushed the bugfix/remove-account-navigation-issue branch from 772ea87 to 96852f3 Compare May 6, 2022 13:54
@LFBarreto LFBarreto merged commit db066b6 into release/3.1.x May 6, 2022
@LFBarreto LFBarreto deleted the bugfix/remove-account-navigation-issue branch May 6, 2022 14:55
This was referenced May 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants