Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(llm): upgrade React Native to 0.72.3 #4289

Merged
merged 25 commits into from
Oct 17, 2023

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Aug 10, 2023

📝 Description

main changes done so far:

applied react native upgrade helper (partially where it makes sense) https://react-native-community.github.io/upgrade-helper/?from=0.71.6&to=0.72.3

gradle upgraded to 8

react native CLI upgraded to 11.3.8 https://github.com/react-native-community/cli#compatibility

upgraded expo to SDK 49 https://blog.expo.dev/expo-sdk-49-c6d398cdf740
expo modules setup: https://docs.expo.dev/bare/installing-expo-modules/#configuration-for-android

upgraded androidX core libs to 1.8.0 to solve this https://issuetracker.google.com/issues/225213324?pli=1

todo / current issues

To test before sending to QA

  • Android
    • QR code scanning → tested with an import account from LLD flow
    • Bluetooth pairing
    • Camera access → tested with an import account from LLD flow
    • Password lock
    • Biometric lock
    • dApp correct render → tested with Paraswap
    • Stax custom lock screen
  • iOS
    • QR code scanning → tested with an import account from LLD flow
    • Bluetooth pairing
    • Camera access → tested with an import account from LLD flow
    • Password lock
    • Biometric lock
    • dApp correct render → tested with Paraswap
    • Stax custom lock screen

To do before sending to dev review

  • changesets
  • proper documentation of the PR (description + comment changes)

❓ Context

  • Impacted projects: llm native-ui live-common
  • Linked resource(s): LIVE-8985

✅ Checklist

  • Test coverage
  • Atomic delivery
  • No breaking changes

📸 Demo

🚀 Expectations to reach

Please make sure you follow these Important Steps.

Pull Requests must pass the CI and be internally validated in order to be merged.

@changeset-bot
Copy link

changeset-bot bot commented Aug 10, 2023

🦋 Changeset detected

Latest commit: 4541d85

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@ledgerhq/native-ui Patch
@ledgerhq/live-common Patch
live-mobile Patch
@ledgerhq/live-cli Patch
ledger-live-desktop Patch
web-tools Patch
@ledgerhq/test-utils Patch
dummy-wallet-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
live-common-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 1:10pm
native-ui-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 1:10pm
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 1:10pm
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 1:10pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 1:10pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 17, 2023 1:10pm

@github-actions github-actions bot added mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library labels Aug 10, 2023
@ofreyssinet-ledger ofreyssinet-ledger changed the title chore(llm): apply react native update diff (without metro config) chore(llm): upgrade React Native to 0.72.3 Aug 10, 2023
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/LIVE-8881-upgrade-react-native-0.72.3 branch from 8c400c6 to e2ddaca Compare August 18, 2023 13:37
@ofreyssinet-ledger ofreyssinet-ledger force-pushed the support/LIVE-8881-upgrade-react-native-0.72.3 branch from 9924014 to 9c47e86 Compare August 22, 2023 08:25
@valpinkman valpinkman force-pushed the support/LIVE-8881-upgrade-react-native-0.72.3 branch from a6849db to a60bbec Compare October 17, 2023 12:52
@gre gre merged commit 29d9d40 into develop Oct 17, 2023
48 checks passed
@gre gre deleted the support/LIVE-8881-upgrade-react-native-0.72.3 branch October 17, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common mobile Has changes in LLM tools Has changes in tools ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants