-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(llm): upgrade React Native to 0.72.3 #4289
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4541d85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
github-actions
bot
added
mobile
Has changes in LLM
common
Has changes in live-common
ui
Has changes in the design system library
labels
Aug 10, 2023
ofreyssinet-ledger
changed the title
chore(llm): apply react native update diff (without metro config)
chore(llm): upgrade React Native to 0.72.3
Aug 10, 2023
1 task
16 tasks
ofreyssinet-ledger
force-pushed
the
support/LIVE-8881-upgrade-react-native-0.72.3
branch
from
August 18, 2023 13:37
8c400c6
to
e2ddaca
Compare
This was referenced Aug 22, 2023
ofreyssinet-ledger
force-pushed
the
support/LIVE-8881-upgrade-react-native-0.72.3
branch
from
August 22, 2023 08:25
9924014
to
9c47e86
Compare
chore: lockfile
valpinkman
force-pushed
the
support/LIVE-8881-upgrade-react-native-0.72.3
branch
from
October 17, 2023 12:52
a6849db
to
a60bbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
main changes done so far:
applied react native upgrade helper (partially where it makes sense) https://react-native-community.github.io/upgrade-helper/?from=0.71.6&to=0.72.3
gradle upgraded to 8
react native CLI upgraded to 11.3.8 https://github.com/react-native-community/cli#compatibility
upgraded expo to SDK 49 https://blog.expo.dev/expo-sdk-49-c6d398cdf740
expo modules setup: https://docs.expo.dev/bare/installing-expo-modules/#configuration-for-android
upgraded androidX core libs to 1.8.0 to solve this https://issuetracker.google.com/issues/225213324?pli=1
todo / current issues
npx expo-doctor
:expo
inapp/build.gradle
and add the ExpoModules package inMainApplication.java
.node
, maybe a proto issue ?invariant
dependency not resolved by nodepnpm ui:native storybook
To test before sending to QA
To do before sending to dev review
❓ Context
llm
native-ui
live-common
✅ Checklist
📸 Demo
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.