Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLM] Promise.allSettled polyfill #6401

Merged
merged 3 commits into from
Mar 25, 2024

Conversation

lvndry
Copy link
Contributor

@lvndry lvndry commented Mar 8, 2024

πŸ“ Description

Some of the libraries we use on LLM use Promise.allSettled however it's not supported natively in mobile environment. So we use add this polyfill to add the support

❓ Context

βœ… Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@lvndry lvndry self-assigned this Mar 8, 2024
Copy link

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools πŸ›‘ Canceled (Inspect) Mar 21, 2024 10:07am
4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 10:07am
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 10:07am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 10:07am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Mar 21, 2024 10:07am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Mar 8, 2024
@lvndry lvndry changed the title promise polyfill [LLM] Promise.allSettled polyfill Mar 8, 2024
@lvndry lvndry force-pushed the feat/live-11636-mobile-promise-allsettled branch from fc16cea to 6f76817 Compare March 8, 2024 17:09
@KVNLS KVNLS marked this pull request as ready for review March 11, 2024 09:25
@KVNLS KVNLS requested a review from a team as a code owner March 11, 2024 09:25
@gre
Copy link
Contributor

gre commented Mar 11, 2024

it is possible that an higher version of Hermes solves this, facebook/hermes#766 (comment)
but i wonder if we are on latest Hermes, maybe updating it would help πŸ€” but i think it means a RN update and it's big, so for now we can go with this polyfill and add ourself a reminder that we may be able to remove in future.

@lvndry lvndry marked this pull request as draft March 11, 2024 15:43
@lvndry lvndry force-pushed the feat/live-11636-mobile-promise-allsettled branch from 6f76817 to 913cd0b Compare March 11, 2024 15:44
@lvndry lvndry force-pushed the feat/live-11636-mobile-promise-allsettled branch from 913cd0b to d87cd4b Compare March 21, 2024 10:03
@lvndry lvndry marked this pull request as ready for review March 21, 2024 10:03
@lvndry lvndry requested a review from a team as a code owner March 21, 2024 10:03
Copy link
Contributor

@hzheng-ledger hzheng-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@hedi-edelbloute hedi-edelbloute merged commit 5713c4b into develop Mar 25, 2024
36 of 47 checks passed
@hedi-edelbloute hedi-edelbloute deleted the feat/live-11636-mobile-promise-allsettled branch March 25, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants