This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
add helium asset info to cryptoassets #724
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #724 +/- ##
=======================================
Coverage 45.07% 45.07%
=======================================
Files 80 80
Lines 4867 4867
Branches 799 805 +6
=======================================
Hits 2194 2194
Misses 2656 2656
Partials 17 17
Continue to review full report at Codecov.
|
gre
reviewed
Dec 24, 2021
| id: "helium", | ||
| coinType: 904, | ||
| name: "Helium", | ||
| managerAppName: "Helium", |
There was a problem hiding this comment.
I don't see any app called Helium at the moment in the Manager. cc @FabriceDautriat
There was a problem hiding this comment.
There should be one. Maybe only visible in developer mode.
gre
approved these changes
Jan 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds asset info for Helium (HNT) to the
@ledgerhq/cryptoassetspackage