Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

Improve the importer to detect possible issues when merging contract #732

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

gre
Copy link
Contributor

@gre gre commented Dec 2, 2021

this will detect this at the moment

found two different abi for same contract! 0x11111112542d85b3ef69ae05771c2dccff4faa26
found two different abi for same contract! 0xdef171fe48cf0115b1d80b88dc8eab59176fee57
found two different abi for same contract! 0x1bd435f3c054b6e901b7b108a0ab7617c808677b

cc @YBadiss

same contract address are expected to have same abi populated as well as selector. otherwise they would be of diff address 🤔

@gre gre requested a review from a team as a code owner December 2, 2021 08:20
@codecov
Copy link

codecov bot commented Dec 2, 2021

Codecov Report

Merging #732 (23d02d5) into master (7bfa1d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #732   +/-   ##
=======================================
  Coverage   45.22%   45.22%           
=======================================
  Files          82       82           
  Lines        4957     4957           
  Branches      795      815   +20     
=======================================
  Hits         2242     2242           
+ Misses       2701     2698    -3     
- Partials       14       17    +3     
Impacted Files Coverage Δ
packages/hw-transport-http/src/HttpTransport.ts 0.00% <0.00%> (ø)
...ckages/hw-transport-http/src/WebSocketTransport.ts 0.00% <0.00%> (ø)
...s/react-native-hw-transport-ble/src/awaitsBleOn.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bfa1d5...23d02d5. Read the comment docs.

@gre gre merged commit 4bcf5bb into master Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant