This repository has been archived by the owner on Jun 27, 2022. It is now read-only.
LL-8941 Automatically release USB connection after 5s #761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #761 +/- ##
==========================================
- Coverage 43.56% 43.43% -0.13%
==========================================
Files 81 81
Lines 4823 4837 +14
Branches 791 792 +1
==========================================
Hits 2101 2101
- Misses 2705 2719 +14
Partials 17 17
Continue to review full report at Codecov.
|
gre
approved these changes
Jan 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of the singleton paradigm, in order to allow third parties to connect with the device we propose introducing a release timeout that allows automatic disconnection of the USB hold after 5s of inactivity. It takes into account pending actions such as "Allow manager", or "Open app" by clearing the timeout before performing the exchange.