Skip to content
This repository has been archived by the owner on Jun 27, 2022. It is now read-only.

LL-8968 throw error of provideNFTInformation #783

Merged
merged 1 commit into from
Jan 31, 2022
Merged

LL-8968 throw error of provideNFTInformation #783

merged 1 commit into from
Jan 31, 2022

Conversation

gre
Copy link
Contributor

@gre gre commented Jan 31, 2022

this implement the minimal part of LL-8968 that is important for the NFT feature.

@gre gre requested a review from a team as a code owner January 31, 2022 11:26
@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #783 (058afac) into master (39ff487) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #783      +/-   ##
==========================================
+ Coverage   43.51%   43.53%   +0.01%     
==========================================
  Files          81       81              
  Lines        4883     4881       -2     
  Branches      859      858       -1     
==========================================
  Hits         2125     2125              
+ Misses       2744     2742       -2     
  Partials       14       14              
Impacted Files Coverage Δ
packages/hw-app-eth/src/Eth.ts 78.82% <ø> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39ff487...058afac. Read the comment docs.

@gre gre merged commit fe8a810 into master Jan 31, 2022
@gre
Copy link
Contributor Author

gre commented Jan 31, 2022

confirmed to work as expected. (manual test)

@gre gre deleted the gre-patch-2 branch January 31, 2022 14:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant