Skip to content
This repository has been archived by the owner on May 30, 2022. It is now read-only.

fix Preferencesbackend binding problem #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hzheng-ledger
Copy link
Contributor

No description provided.

@gre
Copy link
Contributor

gre commented Nov 25, 2020

what is the context of this PR? is there a LLC task attached? thanks

@hzheng-ledger
Copy link
Contributor Author

It fixes compile error. A compile error was found be @gagbo
Basically, we've updated some preferences related binding on the libcore side. we should also update some corresponding stuff on node side.
All changes in this PR are auto generated.
The related PR on lib core : LedgerHQ/lib-ledger-core#665

@hzheng-ledger
Copy link
Contributor Author

hzheng-ledger commented Nov 25, 2020

More detail related to the compile error:
we've changed NJSPreferencebackendCpp into NJSPreferencebackend
if we launch the auto generate binding script on libcore side. It copies NJSPreferencebackend to the src folder
It has both NJSPreferencebackendCpp.cpp and NJSPreferencebackend.cpp and these two files contains same class and it causes an error
So the NJSPreferencebackendCpp.cpp should be removed

@hzheng-ledger
Copy link
Contributor Author

but if you don't need to use the updated binding from libcore
there is no compile error. what I do in this PR is to update the binding on node side.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants