Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the init method trigger also the install #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Ledoux
Copy link
Owner

@Ledoux Ledoux commented Feb 9, 2017

@pocketjoso @franblas

if people wants to first create a project folder <app_name> and inside of it create a venv.
They can actually do then a

tpt init --templates <templates>

and the result will be the same as if they would have done

tpt -c --name <app_name> --templates <templates>

For that I needed to make trigger install in the dump sub task in the case where the program is equel to the init task.

@pocketjoso
Copy link
Collaborator

I'm not sure I see value adding a second way of doing the same thing. What's the use case - when you're too lazy to delete/move an already existing folder to use the tpt -c command from scratch? Imo more important to keep api surface area small than providing convenience for that use case.

@Ledoux
Copy link
Owner Author

Ledoux commented Feb 10, 2017

@pocketjoso
I met two use cases yersterday:

  • one with adrien when he asked how to make internal the python venv in your project. Because you cannot actually create a venv, then create your folder app and after mv your venv inside of it becaus eof path breakings.
  • one with myself when I wanted to create an app already in a git repo that I have initiated from github and git cloned.

But I agree that we don't specially need to talk about this sub-api, it is kind of necessary existing as long as the create method calls it anyway, but it would be useful to mention for people that meet these use cases

@franblas
Copy link
Contributor

@Ledoux The workflow should be to create the venv before creating the app, and people should follow those rules. So the 1st use case you are quoted should not happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants