Window features #26
Merged
Window features #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
LeeVangraefschepe
commented
Nov 5, 2023
LeeVangraefschepe
commented
- Resize toggle
- Icon support (removed from engine added in window)
- Mouse toggle
- Added title set
- Added minimize toggle
- Added hide toggle
- Added require attention flash
- Added window set position
- Added locked aspect ratio
- Added min and max size for window
- Added set size for window
- Removed console from default builds
- -Console Configurations still have the console
- Removed icon constructor - Moved logo.png for default icon - Added SetIcon function in the window class - Added DirectX image data
- Require attention flash - SetPosition - Set AspectRatio - Set min size - Set min & max size - Set size
AtlantiaKing
requested changes
Nov 5, 2023
LeapEngine/GameContext/Window.cpp
Outdated
| else glfwRestoreWindow(m_pWindow); | ||
| } | ||
|
|
||
| void leap::Window::SetHiden(bool value) const |
There was a problem hiding this comment.
Typo: should be SetHidden
UnnamedAdventureGame/main.cpp
Outdated
|
|
||
| int WINAPI WinMain(HINSTANCE, HINSTANCE, LPSTR, int) | ||
| { | ||
| main(); |
There was a problem hiding this comment.
return the value that main returns
| void SetAspectRatio(const glm::ivec2& size) const; | ||
|
|
||
| // Warning this function overrides everything the SetLimitSize does. | ||
| void SetMinimumSize(const glm::ivec2& size) const; |
There was a problem hiding this comment.
Add overloads that take two integers (same for other functions that take glm arguments)
AtlantiaKing
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.