-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a switch for reverting twofold draw visits #1513
Open
Naphthalin
wants to merge
20
commits into
LeelaChessZero:master
Choose a base branch
from
Naphthalin:twofold-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge lc0 master
Merge Master
merge master
merge master
update master branch
increased maximum value of TempDecayMoves from 100 to 640 (LeelaChessZero#1443)
use meson 0.55.3 on appveyor since 0.56.0 is broken (LeelaChessZero#1457)
merge master
merge master
merge master
from Discord, thx to trre:
|
With changes listed above, this test was run at 6s+0.1s
|
Naphthalin
added
the
testing required
Feature/bug fix needs more testing. Implies not for merge.
label
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #1375 was merged, we decided to revert all visits to twofold draws if they were made into non terminals to keep the tree visit consistent. However, this introduced two problematic interactions:
This PR introduces a switch whether to revert twofold visits when the twofold draw node is made non terminal; default behaviour is
--revert-two-fold-visits=false
for testing purposes,=true
is equivalent to the current behaviour.