-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multihead arch with cutlass fused multihead attention #1976
Draft
almaudoh
wants to merge
71
commits into
LeelaChessZero:master
Choose a base branch
from
almaudoh:multihead-arch-cuda-cutlass-fmha
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Multihead arch with cutlass fused multihead attention #1976
almaudoh
wants to merge
71
commits into
LeelaChessZero:master
from
almaudoh:multihead-arch-cuda-cutlass-fmha
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- skip connection add before layer norm now has a scaling factor (alpha) - replace conv layer of value and mlh heads with an embedding layer when attention body is used.
- also remove hardcoding.
- will be removed once it's fixed.
- also fix scratch space calculation.
- factor of sizeof(DataType) was missing.
get almaudoh's code
- to handle bigger/wider networks
1.3% improvement in BT2 on RTX 4090 15.6% improvement in test BT3 network with 64 heads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cutlass implementation of fused multihead attention layer giving about 10% speedup on A100.
@todo