Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the configuration scope to window #698

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adaex
Copy link

@adaex adaex commented May 2, 2021

I found that the current configuration can only be used for user settings. I think this is not very friendly. For example, the workspace folder may be different on different machines. If there are multiple machines, I can only modify the workspace folder before each use.
So I changed the configuration scope to window, which can be configured in user, workspace, or remote settings.

@adaex
Copy link
Author

adaex commented Jul 30, 2021

@jdneo Can you think about this a little bit? I think it is necessary.

@wesleyel
Copy link

#474

any plan to merge this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants