Fix sleep time, add time to debug log, cleaner RPM display #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Legend0fHell
approved these changes
Feb 24, 2024
There was a problem hiding this comment.
Greetings!
I have rechecked everything in the MainThread() function and yes there is a chance that it will cause problems. Switching to the other method helped resolving it!
I honestly thought this repo won't gain any traction so a PR is kinda suprising to me :D. Thanks for the contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Nice program. The only thing I noticed was that when I changed the settings, the CPU started showing high load. I suspected that the refresh time was not what I had set in the settings. I found this problem in the code and tried to fix it to the best of my understanding.
The debugging of this process was helped by refined logging with indication of exact (in milliseconds) time. I decided to keep that too.
I also noticed that the RPM value is not well readable when it is not separated from the unit. I took the liberty of fixing that too :)
I hope my contribution will be useful.