Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lemmy doesnt run / build / compile on Rust 1.48 and nightly #1270

Closed
Nutomic opened this issue Nov 16, 2020 · 4 comments
Closed

Lemmy doesnt run / build / compile on Rust 1.48 and nightly #1270

Nutomic opened this issue Nov 16, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Nutomic
Copy link
Member

Nutomic commented Nov 16, 2020

Due to a problem in the config-rs crate
@Nutomic Nutomic added the bug Something isn't working label Nov 16, 2020
@Nutomic Nutomic mentioned this issue Nov 16, 2020
Closed
@Nutomic Nutomic changed the title Lemmy doesnt build on nightly Lemmy doesnt run on nightly Nov 16, 2020
@Nutomic Nutomic changed the title Lemmy doesnt run on nightly Lemmy doesnt run on Rust 1.48 and nightly Nov 20, 2020
@Nutomic
Copy link
Member Author

Nutomic commented Dec 10, 2020

I have disabled our integration tests, as they are failing due to the crash in config-rs. We need to enable them again once that is fixed.

841ad84#diff-7ff815b68943f08bef79f083c09e55ca8c18db8e25033034b12fa31f1d43dab4

@dessalines
Copy link
Member

Based on @Canop 's recommendations here, and because ~4 libraries are abandoned (config-rs, serde-yaml, hjson-rust (serde-hjson), linked-hash-map), and I think our best bet is to :

  • Remove config-rs entirely.
  • Use @Canop 's deser-hjson library, which should be straightforward since we have a well-typed config anyway.
  • Use this rust merge library, in order to merge our default and custom config
  • Then the only thing we're missing is environment variables, which we could do away with entirely.

@dessalines dessalines pinned this issue Feb 14, 2021
@dessalines dessalines changed the title Lemmy doesnt run on Rust 1.48 and nightly Lemmy doesnt run / build / compile on Rust 1.48 and nightly Feb 14, 2021
dessalines added a commit that referenced this issue Feb 17, 2021
@dessalines
A first attempt at using deser-hjson. Fixes #1270
f19c7a2
@ajyoon ajyoon mentioned this issue Feb 24, 2021
Closed
dessalines added a commit that referenced this issue Feb 25, 2021
@dessalines
Upgrade rust to 1.50.0 . Fixes #1270
b213d6e
@Nutomic Nutomic closed this as completed in 462c4a2 Mar 1, 2021
@Nutomic
Copy link
Member Author

Nutomic commented Mar 1, 2021

This is fixed now, Lemmy runs on Rust 1.50 and nightly :)

@dessalines
Copy link
Member

Yaaaaaaay.

@dessalines dessalines unpinned this issue Mar 1, 2021
Mart-Bogdan added a commit to Mart-Bogdan/lemmy that referenced this issue Mar 13, 2021
@Mart-Bogdan
Merge remote-tracking branch 'origin/main' into 1462-jwt-revocation-o…
7b0a09e 
…n-pwd-change

* origin/main:
  revert Compose file version from 3.3 to 2.2
  Adding more mem limits
  bump memory limit of iframely
  Remove extra category_id s . Fixes LemmyNet#1429
  Fixing wrong user_ and community icon and banner urls.
  Remove category from activitypub context
  Adding a password length check to other API actions. (LemmyNet#1474)
  Update test script
  Use URL type in most outstanding struct fields (LemmyNet#1468)
  Forbid usage of unwrap
  Upgrade Rust version
  Rewrite settings implementation. Fixes LemmyNet#1270 (LemmyNet#1433)
  Rename `lemmy_structs` to `lemmy_api_structs`

# Conflicts:
#	crates/db_schema/src/source/user.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dessalines @Nutomic