Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fails if voyager.lemmy.ml is down #4870

Closed
Nutomic opened this issue Jun 26, 2024 · 1 comment · Fixed by #4891
Closed

Test fails if voyager.lemmy.ml is down #4870

Nutomic opened this issue Jun 26, 2024 · 1 comment · Fixed by #4891

Comments

@Nutomic
Copy link
Member

Nutomic commented Jun 26, 2024

https://woodpecker.join-lemmy.org/repos/129/pipeline/8068/19

test scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml ... FAILED
failures:
---- scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml stdout ----
Error: LemmyError { message: CouldntFindObject, inner: CouldntFindObject
Stack backtrace:
   0: anyhow::error::<impl anyhow::Error>::msg
   1: <lemmy_utils::error::LemmyError as core::convert::From<lemmy_utils::error::LemmyErrorType>>::from
   2: <core::result::Result<T,F> as core::ops::try_trait::FromResidual<core::result::Result<core::convert::Infallible,E>>>::from_residual
   3: lemmy_server::scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml::{{closure}}::{{closure}}
   4: <core::pin::Pin<P> as core::future::future::Future>::poll
   5: <core::pin::Pin<P> as core::future::future::Future>::poll
   6: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}::{{closure}}
   7: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}::{{closure}}
   8: tokio::runtime::scheduler::current_thread::Context::enter
   9: tokio::runtime::scheduler::current_thread::CoreGuard::block_on::{{closure}}
  10: tokio::runtime::scheduler::current_thread::CoreGuard::enter::{{closure}}
  11: tokio::runtime::context::scoped::Scoped<T>::set
  12: tokio::runtime::context::set_scheduler::{{closure}}
  13: std::thread::local::LocalKey<T>::try_with
  14: std::thread::local::LocalKey<T>::with
  15: tokio::runtime::context::set_scheduler
  16: tokio::runtime::scheduler::current_thread::CoreGuard::enter
  17: tokio::runtime::scheduler::current_thread::CoreGuard::block_on
  18: tokio::runtime::scheduler::current_thread::CurrentThread::block_on::{{closure}}
  19: tokio::runtime::context::runtime::enter_runtime
  20: tokio::runtime::scheduler::current_thread::CurrentThread::block_on
  21: tokio::runtime::runtime::Runtime::block_on
  22: lemmy_server::scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml::{{closure}}
  23: core::ops::function::FnOnce::call_once
  24: serial_test::serial_code_lock::local_serial_core_with_return
  25: lemmy_server::scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml
  26: lemmy_server::scheduled_tasks::tests::test_nodeinfo_voyager_lemmy_ml::{{closure}}
  27: core::ops::function::FnOnce::call_once
  28: test::__rust_begin_short_backtrace
  29: test::run_test::{{closure}}
  30: std::sys_common::backtrace::__rust_begin_short_backtrace
  31: core::ops::function::FnOnce::call_once{{vtable.shim}}
  32: std::sys::pal::unix::thread::Thread::new::thread_start
  33: <unknown>
  34: clone, context: SpanTrace [] }

Tests shouldnt rely on any external servers. Or at least it should be changed to use lemmy.ml, because a test instance is more likely to be down.

@dessalines
Copy link
Member

I originally couldn't test using lemmy.ml, because that fix hadn't been deployed yet. But I think I can do it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants