[Bug]: Email notifications for new registrations are no longer sent

[Illecors]

Requirements

• Is this a bug report? For questions or discussions use https://lemmy.ml/c/lemmy_support
• Did you check to see if this issue already exists?
• Is this only a single bug? Do not put multiple bugs in one issue.
• Do you agree to follow the rules in our Code of Conduct?
• Is this a backend issue? Use the lemmy-ui repo for UI / frontend issues.

Summary

Starting with 0.19 my instance no longer sends out registration notification emails. Email itself is working fine - reports and registration verification is sent out correctly.

Postfix logs only show a single connection attempt as well.

Steps to Reproduce

1. Sign up at lemmy.cafe

Technical Details

lemmy.log

Version

0.19.5

Lemmy Instance URL

https://lemmy.cafe

[dessalines]

Here's the code for that: https://github.com/LemmyNet/lemmy/blob/main/crates/api_crud/src/user/create.rs#L190

Do you have require_email_verification turned on? If so, it shouldn't send one out until after they've verified their email.

[Illecors]

I do have require_email_verification turned on. I think it used to work exactly the way you describe - after the applicant confirmed their email address.

The comment on line 190 and the following if implies that it actually would not send out an email. If that's expected - should I raise a feature request?

[Nutomic]

In that case the admin notification is sent out after the user verified his email address. However the check for RegistrationMode::RequireApplication seems wrong and is probably causing your problem as you have applications disabled.