Dont exit early when running only scheduled tasks #4707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nutomic
requested review from
dessalines,
phiresky,
dullbananas and
SleeplessOne1917
as code owners
5 tasks
SleeplessOne1917
approved these changes
May 7, 2024
|
This makes the migration check in CI run forever |
dullbananas
reviewed
May 7, 2024
| @@ -218,17 +218,15 @@ pub async fn start_lemmy_server(args: CmdArgs) -> LemmyResult<()> { | |||
| let mut interrupt = tokio::signal::unix::signal(SignalKind::interrupt())?; | |||
| let mut terminate = tokio::signal::unix::signal(SignalKind::terminate())?; | |||
|
|
|||
| if server.is_some() || federate.is_some() { | |||
There was a problem hiding this comment.
Replace this with an environment variable check and set the variable in CI. This check can be removed in #4673.
There was a problem hiding this comment.
Most pipeline runners set CI env var automatically. Including Woodpecker you can use that one instead.
There was a problem hiding this comment.
That would work if there's an env var that's different for each step
|
I think this approach is simpler. |
Nutomic
force-pushed
the
scheduled_tasks_await
branch
from
b0f3c60 to
b3d9d7d
Compare
dessalines
approved these changes
May 8, 2024
dullbananas
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lemmy would exit immediately when running only scheduled tasks, instead of running forever as it should. It was broken in this commit.
Edit: You can test it with
cargo run -- --disable-http-server --disable-activity-sending