Use trigger to generate apub URL in insert instead of update, and fix query planner options not being set when TLS is disabled #4797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dullbananas
changed the title
generate_local_apub_endpoint with triggersThis reverts commit 028eabb.
dullbananas
requested review from
dessalines,
phiresky,
Nutomic and
SleeplessOne1917
as code owners
Nutomic
reviewed
Jun 26, 2024
| // provide a setup function which handles creating the connection | ||
| let mut config = ManagerConfig::default(); | ||
| config.custom_setup = Box::new(establish_connection); | ||
| let manager = AsyncDieselConnectionManager::<AsyncPgConnection>::new_with_config(&db_url, config); |
There was a problem hiding this comment.
This is unrelated, better to put it into a separate PR. Or is it just leftover from merging?
There was a problem hiding this comment.
Sorry, forgot to explain this.
This fixes a mistake that caused the configuration updates in the establish_connection function to only run if TLS is enabled, which started to break tests in this PR.
The other change here is adding lemmy.protocol_and_hostname to the config options. batch_execute is no longer used because it doesn't allow bind parameters.
Nutomic
reviewed
Jun 26, 2024
| CREATE TRIGGER change_values | ||
| BEFORE INSERT ON private_message | ||
| FOR EACH ROW | ||
| EXECUTE FUNCTION r.private_message_change_values (); |
There was a problem hiding this comment.
Where is the trigger for comment?
There was a problem hiding this comment.
For comments, an existing trigger was updated. It's the first change in this file.
dullbananas
changed the title
Nutomic
approved these changes
Jun 28, 2024
Nutomic
pushed a commit
to sunaurus/lemmy
that referenced
this pull request
Sep 20, 2024
… query planner options not being set when TLS is disabled (LemmyNet#4797) * Update create.rs * Update utils.rs * Update utils.sql * Update triggers.sql * Update utils.sql * Update create.rs * Update create.rs * Update create.rs * Update create.rs * Update create.rs * Update create.rs * Update create.rs * Update create.rs * Create up.sql * Update up.sql * Update triggers.sql * Update utils.rs * stuff * stuff * revert some changed files * Revert "revert some changed files" This reverts commit 028eabb. * revert the correct files * partial reverts * migration, tests, fix establish_connection * lint * pg_format
This was referenced Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.