Implement fingerprint randomart generation #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leo1003
added
Priority: Medium
|
LGTM! Thanks for your contribution! |
Leo1003
approved these changes
Feb 11, 2022
Leo1003
added
Status: Done
Leo1003
added a commit
that referenced
this pull request
Feb 11, 2022
Leo1003
added a commit
that referenced
this pull request
Feb 11, 2022
|
Happy to help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ported the
fingerprint_randomartalgorithm from the OpenSSH project into my personal project, but when looking at this project's goal, I thought it might be interesting to incorporate the code into this project as well.The algorithm itself is more or less copied from the
sshkey.cfrom theopenssh-portablerepository file and rustified, so I included the OpenBSD notice above the trait method.I have also extended some traits so that short names of the different keys can be fetched easily as well, since this is used in the output of the fingerprint randomart.
Finally, I extended the tests so that the expected fingerprint randomart (which is what is output from
ssh-keygen -lvf <keyfile>) can be detected.