use Object.create(null) to create all parsed objects #603
+20
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is even more important to merge because it Closes #663. |
|
@Leonidas-from-XIV What do you think? This PR will fix the exploit reported against the latest version. |
|
I am sort of wondering if this needs to be a breaking change? I could imagine just checking for |
|
Actually, scratch that, you can inject shenanigans like |
Leonidas-from-XIV
referenced
this pull request
Apr 11, 2023
3 tasks
Leonidas-from-XIV
added a commit
that referenced
this pull request
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent parsing of documents containing tags or attributes named
__proto__from overwriting the prototype on returned objects (See #593)This is a breaking change, and will break any users of this library which use, for example
.hasOwnPropertyon the returned objects. (The tests here have been updated to avoid this).