Add hidden abortOnClose option to iterators
#21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise they're lost when an implementation clones options.
Will be used by `many-level`.
43 tasks
15 tasks
vweevers
added a commit
that referenced
this pull request
Nov 14, 2022
In #50 I made an early start with this, but I made two mistakes: 1. Putting the signal in per-method options, e.g. `next({ signal })`, rather than in constructor options, i.e. `iterator({ signal })`. The former would not be accessible in a `for await...of` and come with a performance penalty. 2. Thinking it could replace `abortOnClose` (#21), which is a separate issue. I'll leave it at that, because it only matters for `many-level` and can be solved later. Anyway, this PR enables the following: ``` const abortController = new AbortController() const signal = abortController.signal // Will result in 'aborted' log abortController.abort() try { for await (const entry of db.iterator({ signal })) { console.log(entry) } } catch (err) { if (err.code === 'LEVEL_ABORTED') { console.log('aborted') } } ``` It also fixes small bugs in the `open()` and `close()` methods of multiple classes, as follow-up for #50.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.