-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop legacy features & runtime environments #374
Merged
+613
−620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An error is now thrown when an iterator is created with one of these options. Ref Level/community#86
vweevers
added
semver-major
Changes that break backward compatibility
maintenance
General maintenance
labels
Apr 3, 2021
83 tasks
ralphtheninja
approved these changes
Apr 5, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor note on self
variables.
vweevers
force-pushed
the
updates
branch
3 times, most recently
from
April 8, 2021 13:00
1b7455a
to
8240c24
Compare
So that we can use async generators (in a future release).
And also use it in the test suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR drops support of:
start
andend
(Remove start & end from range options community#86)This allows us to remove
xtend
, use latest dependencies (nyc
,sinon
,standard
) which in turn removes vulnerabilities, and to use async generators (in a future semver-minor PR). Easiest to review commit by commit; do not squash on merge.Ref Level/community#98.
FYI @achingbrain because this slightly delays the release of your #373.