-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add db.getMany(keys)
#381
Add db.getMany(keys)
#381
Conversation
|
||
this._getMany(serialized, options, callback) | ||
return callback.promise | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that here we're doing everything that levelup normally does, as an experiment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which means that levelup
only has to do this:
LevelUP.prototype.getMany = function (keys, options, callback) {
return this.db.getMany(keys, options, callback)
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So later on we can move over the catering
stuff to abstract-leveldown
one by one.
Added in the last commit (1f1ab97):
And removed:
|
Tested against
leveldown
,memdown
,level-js
,deferred-leveldown
,encoding-down
, (indirectly)levelup
,subleveldown
.Ref Level/community#101