Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention that null and undefined values are not supported #125

Merged
merged 1 commit into from
May 27, 2018

Conversation

vweevers
Copy link
Member

Closes #105.

@@ -17,7 +17,7 @@ Here are the goals of `level-js`:
- Pass the full `abstract-leveldown` test suite
- Support [Buffer](https://nodejs.org/api/buffer.html) values (in all target environments)
- Support all key types of IndexedDB Second Edition, including binary keys (depends on environment)
- Support all value types of the structured clone algorithm (depends on environment)
- Support all value types of the structured clone algorithm (depends on environment) except for `null` and `undefined`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention something about writing them as empty strings if they are used as values?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. We can do that as part of #123

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(which is a bigger effort)

@vweevers vweevers merged commit 3a8b861 into master May 27, 2018
@vweevers vweevers deleted the mention-nullish branch May 27, 2018 14:14
@vweevers vweevers mentioned this pull request May 27, 2018
@vweevers vweevers added the upgrade guide Improvements or additions to upgrade guide(s) label Jun 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade guide Improvements or additions to upgrade guide(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants